Conversation
TypeScript handles undefined variable checking better than ESLint's no-undef rule. This fixes CI failures where no-undef doesn't understand TypeScript types like TimerHandler. Reverts the inline type workaround and removes type-only globals that were only needed to suppress no-undef. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace pull_request_target with pull_request so actions/checkout checks out the PR branch instead of the base branch. This ensures the ESLint no-undef fix is actually tested in CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.