Open
Conversation
Tidying the code with checks to allow for altering tag set.
maintenance of the English version. Removing much of the hard coded lists into linguistic constants at the start of the file.
the fine grained tagger tags and the dependency parser tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Kris,
I have made some changes to the TAASSC214_dev.py program. Essentially all my edits are just housekeeping.
I moved all the word lists I could find to global constants at the top of the file.
I changed both the function that read in the wordlists and the wordlist file format to avoid any hard coding of slices.
I changed the functions that deal with noun_normalizations to avoid hard coding of lists and lengths.