Skip to content

Improve proposal numbering workflow with exact commands to name proposal file given in feedback added to the description etc#106

Merged
k-wall merged 3 commits into
kroxylicious:mainfrom
k-wall:main
Apr 28, 2026
Merged

Improve proposal numbering workflow with exact commands to name proposal file given in feedback added to the description etc#106
k-wall merged 3 commits into
kroxylicious:mainfrom
k-wall:main

Conversation

@k-wall
Copy link
Copy Markdown
Member

@k-wall k-wall commented Apr 28, 2026

Follow-up improvements to #104 to provide exact, copy-pasteable commands.

Workflow Changes

The GitHub workflow now generates specific, copy-pasteable commands for each proposal:

  • Exact git mv command with actual current and expected filenames
  • Smart sed command that preserves title text while fixing the number prefix
  • git add to stage the file after sed modification
  • Complete workflow including git commit and git push

Example output:

git mv proposals/xxx-test-feature.md proposals/105-test-feature.md
# Update title: remove any old number prefix and add PR number
sed -i.bak '0,/^# /{s/^# \([0-9]\{3\}\|xxx\|nnn\|000\) - /# 105 - /; t; s/^# /# 105 - /}' proposals/105-test-feature.md && rm proposals/105-test-feature.md.bak
git add proposals/105-test-feature.md
git commit -m "Rename proposal to use PR number 105"
git push

The sed command handles all common title formats:

  • # 000 - Title# 105 - Title
  • # xxx - Title# 105 - Title
  • # nnn - Title# 105 - Title
  • # Title# 105 - Title

Notification Script Changes

Updated notify-open-prs.sh to generate PR-specific comments:

  • Fetches the actual proposal filename from each PR
  • Calculates the expected filename
  • Provides exact commands including sed for title update
  • Includes git add after file modification

Testing

Tested with a proposal having # xxx - Test Exact Commands:

  • Commands worked correctly when copy/pasted
  • Title updated to # 4 - Test Exact Commands (text preserved)
  • Workflow automatically removed warning after fixes applied

Assisted-By: Claude Sonnet 4.5 noreply@anthropic.com
Signed-off-by: Keith Wall kwall@apache.org

k-wall added 2 commits April 28, 2026 10:43
Update the workflow to generate specific fix commands for each proposal:
- Exact git mv command with actual current and expected filenames
- Smart sed command that preserves title text while fixing the number
- Include git commit and git push for complete fix workflow

The sed command handles titles with or without existing number prefixes
(e.g., '# 000 - Title', '# xxx - Title', or '# Title') and automatically
adds the correct PR number while preserving the title text.

Users can now copy/paste the entire command block directly into their
terminal without manual editing.

Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Keith Wall <kwall@apache.org>
Workflow Changes:
- Generate specific, copy-pasteable commands for each proposal
- Exact git mv command with actual current and expected filenames
- Smart sed command that preserves title text while fixing the number
- Include git add after sed to stage the modified file
- Complete workflow with git commit and git push

Notification Script Changes:
- Fetch actual proposal filename from each PR
- Calculate expected filename
- Provide exact commands including sed for title update
- Include git add after sed modification

The sed command handles all common title formats (# 000 -, # xxx -,
# nnn -, or plain # Title) and preserves the title text.

Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Keith Wall <kwall@apache.org>
@k-wall k-wall requested a review from a team as a code owner April 28, 2026 09:59
This is a local settings file that shouldn't be tracked.

Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Keith Wall <kwall@apache.org>
@k-wall k-wall changed the title Improve proposal numbering workflow with exact commands Improve proposal numbering workflow with exact commands to name proposal file etc Apr 28, 2026
@k-wall k-wall changed the title Improve proposal numbering workflow with exact commands to name proposal file etc Improve proposal numbering workflow with exact commands to name proposal file given in feedback added to the description etc Apr 28, 2026
@k-wall k-wall merged commit 88dfa9b into kroxylicious:main Apr 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants