Fix re-taint in bootstrap-only mode when annotation fails

[rawadhossain]

Description

Fixes an issue where nodes can get re-tainted in bootstrap-only mode if the bootstrap completion annotation fails to be written.

Currently, the controller removes the taint but doesn’t record completion if the annotation write fails. This can cause the controller to treat the node as incomplete and reapply the taint on later reconciles.

To fix this:

• made sure errors from the annotation write aren’t ignored
• kept NodeEvaluation in sync even if the annotation step fails
• skipped nodes that are already marked as bootstrap-completed during rule reconciliation

This keeps bootstrap-only behavior consistent after the first successful taint removal.

Related Issue

Fixes #207

Type of Change

/kind bug
/kind cleanup

Testing

• Added tests to cover:
  • annotation patch failure after taint removal
  • skipping evaluation when bootstrap is already completed
• Ran:
  • make test
  • make lint

Checklist

• make test passes
• make lint passes

[netlify]

✅ Deploy Preview for node-readiness-controller canceled.

Name	Link
🔨 Latest commit	5c40403
🔍 Latest deploy log	https://app.netlify.com/projects/node-readiness-controller/deploys/69fb13271fb5670008855b12

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rawadhossain
Once this PR has been reviewed and has the lgtm label, please assign haircommander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @rawadhossain. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ajaysundark]

/ok-to-test