Fix/remove dead nil selector check

[dorodb-web22]

Description

metav1.LabelSelectorAsSelector is called with &oldRule.Spec.NodeSelector, where NodeSelector is a struct value, not a pointer. It never returns nil, nil ; an empty struct yields labels.Everything(), which correctly matches all nodes. The subsequent if oldSelector == nil branch was therefore dead code and could never be reached.

Remove the nil check and call oldSelector.Matches(...) directly.

Related Issue

Fixes #230

Type of Change

/kind cleanup

Testing

make test
make lint

Checklist

• make test passes
• make lint passes

Does this PR introduce a user-facing change?

NONE

[netlify]

✅ Deploy Preview for node-readiness-controller canceled.

Name	Link
🔨 Latest commit	fc5b44b
🔍 Latest deploy log	https://app.netlify.com/projects/node-readiness-controller/deploys/6a003e340fc1290008a2f395

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dorodb-web22
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @dorodb-web22. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ajaysundark]

Thanks for your PR. Please note this is also addressed here: #229. Can you coordinate with the other author?

[ajaysundark]

ah I see your original PR: #222. This possibly is carrying your earlier changes as well. Can you scope the changes in this PR to only nil check?

[dorodb-web22]

@ajaysundark Good catch, I had accidentally branched from another PR instead of main. i have now force-pushed a cleaned-up version scoped only to the nil check in nodereadinessrule_controller.go. Thanks....

[ajaysundark]

/ok-to-test