refactor(readiness-condition-reporter): swap context.TODO() for content.Background()#239
Conversation
…xt.Background() in tests
✅ Deploy Preview for node-readiness-controller canceled.
|
|
Welcome @LightCreator1007! |
|
Hi @LightCreator1007. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Karthik-K-N
left a comment
There was a problem hiding this comment.
Thanks for the PR
LGTM
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajaysundark, LightCreator1007 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR replaces the usage of
context.TODO()withcontext.Background()incmd/readiness-condition-reporter/main_test.go.This change cleans up the codebase and enforces Go's best practices. It does not alter any existing application logic or data flows.
Related Issue
None
Type of Change
/kind cleanup
Testing
main_test.go).TestCheckHealth,TestCheckHealthCancelledContext, andTestUpdateNodeConditioncontinue to pass successfully with the updated context.Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?