fix(generators): detect inline fields structurally instead of matching ",inline" tag#587
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Apr 14, 2026
Conversation
…g ",inline" tag Determine whether a field should be inlined based on whether it is embedded and has an empty json tag name, rather than checking for the literal ",inline" json tag option which is not a real encoding/json directive. This allows types to use `json:""` instead of `json:",inline"` on embedded fields like TypeMeta, ObjectMeta, and ListMeta.
k8s-ci-robot
added
size/L
Member
Author
|
/assign @liggitt |
Member
Author
|
/assign @jpbetz for review and approval |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase, Jefftree, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Determine whether a field should be inlined based on whether it is embedded and has an empty json tag name, rather than checking for the literal ",inline" json tag option which is not a real encoding/json directive.
This allows types to use
json:""instead ofjson:",inline"on embedded fields like TypeMeta, ObjectMeta, and ListMeta.xref: kubernetes/kubernetes#138260