-
Notifications
You must be signed in to change notification settings - Fork 41.9k
Fix data race in garbage collector on node.owners field #135647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add ownersLock to protect concurrent access to node.owners between GraphBuilder.processGraphChanges() (writer) and GC worker goroutines reading in blockingDependents() and unblockOwnerReferences() methods. Also fix concurrent reads in the HTTP debug handler (/graph endpoint) for owners, dependents, beingDeleted, deletingDependents, and virtual fields by using their respective thread-safe accessor methods.
|
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sat Dec 6 15:39:20 UTC 2025. |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @grandeit. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: grandeit The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Add ownersLock to protect concurrent access to node.owners between GraphBuilder.processGraphChanges() (writer) and GC worker goroutines reading in blockingDependents() and unblockOwnerReferences() methods.
Also fix concurrent reads in the HTTP debug handler (/graph endpoint) for owners, dependents, beingDeleted, deletingDependents, and virtual fields by using their respective thread-safe accessor methods.
Which issue(s) this PR is related to:
Fixes: #135621
Special notes for your reviewer:
The fix follows the existing locking pattern in the node struct (dependentsLock, beingDeletedLock, etc.). GraphBuilder's own reads of
node.ownersremain as direct field access since it is single-threaded and the only writer.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: