Initial cut of external plugin support for NPD#1281
Open
dims wants to merge 1 commit into
Open
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
dims
force-pushed
the
initial-cut-of-external-plugin-support-for-npd
branch
from
239820b to
fbf84fa
Compare
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
initial-cut-of-external-plugin-support-for-npd
branch
from
fbf84fa to
08a4e88
Compare
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: #833
As a first step to GPU support, we want to avoid running scripts repeatedly and have something running that NPD can talk to over GRPC. I did some experiments in:
https://github.com/dims/npd-ext
Filing this PR as a first step. I've included a sample
examples/external-plugins/gpu-monitorthat just runs nvidia-smi.NOTE that the protos are based off the same handshake that external plugins currently use. So this mechanism is NOT just for GPUs in any way.
Please see
docs/external-plugins.mdfor more info.