Skip to content

Add coverage target using rcov #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kwerle merged 7 commits into from
Dec 31, 2025
Merged

Add coverage target using rcov #115

kwerle merged 7 commits into from
Dec 31, 2025
+25 −0

Conversation

Copy link
Contributor

Copilot AI commented Dec 31, 2025 •
edited
Loading

  • Understand the current test infrastructure and Makefile structure
  • Add rcov gem as a development dependency to gemspec
  • Create a coverage target in Makefile that runs tests with coverage
  • Improve coverage command with proper include paths (-Ilib:spec)
  • Remove redundant gem install since rcov is in gemspec
  • Run code review and address feedback
  • Run security checks (no issues found)
  • Remove -it flags from coverage target (not needed for non-interactive command)
  • Final verification complete
Original prompt

This section details on the original issue you should resolve

<issue_title>Add a coverage target</issue_title>
<issue_description>rcov.

The make target should install the gem and run the tests using rcov.</issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits December 31, 2025 02:21
@kwerle
Add coverage target with rcov support
0f85ebd 
Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
@kwerle
Add include paths to rcov command for proper test execution
1187c7e 
Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
@kwerle
Remove redundant gem install from coverage target
c857543 
Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
Copilot AI changed the title [WIP] Add coverage target for rcov tests Add coverage target using rcov Dec 31, 2025
Copilot AI requested a review from kwerle December 31, 2025 02:26
kwerle
kwerle requested changes Dec 31, 2025
View reviewed changes
Makefile Outdated
docker run -it --rm $(LOCAL_LINK) $(PROJECT_NAME) sh -c 'bundle exec rake test && bundle exec rubocop'

coverage: image
docker run -it --rm $(LOCAL_LINK) $(PROJECT_NAME) sh -c 'bundle exec rcov -Ilib:spec spec/**/*_spec.rb'
Copy link
Owner

@kwerle kwerle Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not use -it

Copy link
Contributor Author

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 4ef35a3. Removed -it flags from the coverage target.

@kwerle
Remove -it flags from coverage target
4ef35a3 
Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
Copilot AI requested a review from kwerle December 31, 2025 02:32
@kwerle kwerle marked this pull request as ready for review December 31, 2025 03:17
@kwerle kwerle merged commit 741400e into develop Dec 31, 2025
3 of 4 checks passed
@kwerle kwerle deleted the copilot/add-coverage-target branch December 31, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kwerle kwerle kwerle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kwerle kwerle

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a coverage target

2 participants

@kwerle