Conversation
Add alias field to ImageV2FilterGQL input type and wire it to ImageAliasConditions.by_alias_* factories in build_conditions(), supporting contains, equals, startsWith, and endsWith operations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds GraphQL filtering support for image aliases by extending ImageV2FilterGQL and wiring the filter into query condition building.
Changes:
- Add
alias: StringFiltertoImageV2FilterGQL. - Build query conditions for alias using
ImageAliasConditions.by_alias_*factories. - Add a changelog entry documenting the new alias filter support.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ai/backend/manager/api/gql/image/types.py | Adds alias to the GraphQL filter input and wires it into build_conditions() via ImageAliasConditions. |
| changes/9563.feature.md | Documents the new alias filtering feature in the changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: octodog <mu001@lablup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alias: StringFilterfield toImageV2FilterGQLinput typeImageAliasConditions.by_alias_*factories inbuild_conditions()contains,equals,startsWith, andendsWithoperations on image aliasesTest plan
aliasfield onImageV2FilterGQLcontains,equals,startsWith,endsWithResolves BA-4818