Skip to content

Run bundle fix only if GUI is build on macOS #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mscheltienne wants to merge 1 commit into from
Closed

Run bundle fix only if GUI is build on macOS #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ endif(Qt6_FOUND AND BUILD_GUI)
set(CPACK_DEBIAN_LABRECORDER_PACKAGE_SECTION "science" CACHE INTERNAL "")
LSLGenerateCPackConfig()

if(APPLE AND NOT DEFINED ENV{GITHUB_ACTIONS})
if(APPLE AND BUILD_GUI AND NOT DEFINED ENV{GITHUB_ACTIONS})
# Qt6 QtNetwork depends on libbrotidec which depends on libbroticommon but whose search path uses @loader_path.
# Unfortunately, macdeployqt does not seem to traverse @loader_path dependencies.
# So we are forced to call `fixup_bundle`. For now, we only do this if homebrew is present
Expand Down Expand Up @@ -207,4 +207,4 @@ if(APPLE AND NOT DEFINED ENV{GITHUB_ACTIONS})
execute_process(COMMAND codesign --force --deep --sign - \"${CMAKE_INSTALL_PREFIX}/${PROJECT_NAME}/${PROJECT_NAME}.app\") "
)
endif()
endif(APPLE AND NOT DEFINED ENV{GITHUB_ACTIONS})
endif(APPLE AND BUILD_GUI AND NOT DEFINED ENV{GITHUB_ACTIONS})