fix: disable freecam on dimension change

[VadimTotok]

prevents a freeze caused by conflicts between Freecam logic and world reinitialization during teleportation

[IceTank]

There is a different pr that fixes the same issue without disabling the freecam module. That one should be preferred.

[VadimTotok]

There is a different pr that fixes the same issue without disabling the freecam module. That one should be preferred.

All popular clients use exactly this type of protection against game crashes.

Disabling the freecam module is a lightweight and safe fix - it prevents the crash. I've reviewed the solution from another pr, and here's why it's worse: the game doesn't crash, but you lose a lot of performance. Loading the world takes twice as long or even more - it's very slow and inefficient.

My solution doesn't lose performance and does exactly the same thing every popular client does to solve this problem.

[IceTank]

There is a different pr that fixes the same issue without disabling the freecam module. That one should be preferred.

All popular clients use exactly this type of protection against game crashes.

Disabling the freecam module is a lightweight and safe fix - it prevents the crash. I've reviewed the solution from another pr, and here's why it's worse: the game doesn't crash, but you lose a lot of performance. Loading the world takes twice as long or even more - it's very slow and inefficient.

My solution doesn't lose performance and does exactly the same thing every popular client does to solve this problem.

Is this response AI-generated? I didn't notice any performance impact.

Disabling modules without user input is very annoying if you have multiple modules bound to the same key. We aim not to disable any modules without explicit user input.

[VadimTotok]

There is a different pr that fixes the same issue without disabling the freecam module. That one should be preferred.

All popular clients use exactly this type of protection against game crashes.

Disabling the freecam module is a lightweight and safe fix - it prevents the crash. I've reviewed the solution from another pr, and here's why it's worse: the game doesn't crash, but you lose a lot of performance. Loading the world takes twice as long or even more - it's very slow and inefficient.

My solution doesn't lose performance and does exactly the same thing every popular client does to solve this problem.

Is this response AI-generated? I didn't notice any performance impact.

Disabling modules without user input is very annoying if you have multiple modules bound to the same key. We aim not to disable any modules without explicit user input.

which module will the user want to bind to the same button that freecam is binding to? in my case, the loading of the world was very long, the game did not crash, but the loading time was very long. I checked it several times. I have a good computer. if you disable the freecam module, everything will work as it should in good clients. because it makes no sense to leave the freecam module enabled! This is nonsense!

[IceTank]

Ah is see what you mean now. The long loading screen was a bug in the implementation. But that should be fixed now.

Freecam has a feature to stay in a position relative to the player. Some people might toggle freecam and something like autowalk or highway tools with the same key.

[VadimTotok]

Ah is see what you mean now. The long loading screen was a bug in the implementation. But that should be fixed now.

Freecam has a feature to stay in a position relative to the player. Some people might toggle freecam and something like autowalk or highway tools with the same key.

okay, but it doesn't fit the dimension change scenario. therefore, turning off freecam is still the best decision that can be made, and it will not have consequences. I'm not suggesting that the player randomly disable the freecam module. I highly doubt that players need to leave the freecam on when they have changed the dimension.

[IceTank]

I don't understand what you mean by dimension change