feat: add CheckpointResult type for checkpoint() return value#11
Merged
Conversation
- Add PyCheckpointResult frozen pyclass with checkpoint_id getter, __bool__, __int__, and __repr__ support - Change Connection.checkpoint() to return CheckpointResult instead of int | None - Add CheckpointResult to type stubs, exports, and __all__ - Add deprecation note to CheckpointStatus in types.py - Add comprehensive test suite (10 tests) covering disabled/enabled checkpointing, result properties, and after-close behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckpointResultfrozen pyclass that wraps the checkpoint ID withcheckpoint_idgetter,__bool__,__int__, and__repr__supportConnection.checkpoint()to returnCheckpointResultinstead ofint | NoneCheckpointStatusdataclassTest plan
cargo checkandcargo clippy -- -D warningspass cleanpytest tests/test_checkpoint.py -v— all 10 new tests passpytest tests/ -v— all 242 tests pass (no regressions)