Skip to content

ci: add Makefile and GitHub Actions workflow for PR checks#25

Open
wombatu-kun wants to merge 3 commits into
lance-format:mainfrom
wombatu-kun:build/ci-makefile
Open

ci: add Makefile and GitHub Actions workflow for PR checks#25
wombatu-kun wants to merge 3 commits into
lance-format:mainfrom
wombatu-kun:build/ci-makefile

Conversation

@wombatu-kun
Copy link
Copy Markdown

@wombatu-kun wombatu-kun commented Apr 22, 2026

Summary

Adds the canonical local build entry point (Makefile) and the main CI
workflow (.github/workflows/flink.yml).

After merge, every PR against main is gated by two jobs:

  • lintmvn spotless:check checkstyle:check
  • build-and-testmvn install -DskipTests followed by mvn test

Both run on Ubuntu 24.04 with Temurin 8 (matching
maven.compiler.target=1.8 and Flink 1.16.1 native Java) and use the
actions/setup-java Maven cache. Concurrency is configured to cancel
in-progress runs when new commits land on a PR.

Stacking

This PR is stacked on top of build/code-style-setup (Spotless,
Checkstyle, Enforcer plugin configuration) and chore/apply-initial-formatting
(initial spotless:apply pass over the existing sources). The PR diff
currently includes their commits as well; once both upstream PRs merge
and this branch is rebased onto main, only the two new files remain.

Forward compatibility

The Makefile exposes install-all, test-all, build-all aliases
that currently forward to their single-module counterparts. These are
reserved for a future multi-module iteration pattern over
FLINK_VERSION, so .github/workflows/flink.yml will not need to be
rewritten when that lands.

@github-actions github-actions Bot added the ci CI/CD related changes label May 24, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@wombatu-kun
Copy link
Copy Markdown
Author

Heads-up on the build-and-test failure here: this PR adds the test-running CI workflow, which surfaces a pre-existing failure on mainLanceReadOptimizationsTest.testInPredicatePushDown asserts IN-predicate pushdown, but that implementation lives in #21 and isn't on main yet. So this job stays red until #21 merges; once #21 is in main, rebasing this branch turns it green. Suggested merge order: #21 before this PR. (lint passes; the sole failing test is the one #21 fixes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant