feat(namespace): add count_table_rows, insert_into_table, query_table#6132
Conversation
eb5404d to
cb74abf
Compare
PR ReviewP0:
|
cb74abf to
cf62c9d
Compare
6085325 to
5e24dff
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
yanghua
left a comment
There was a problem hiding this comment.
@XuQianJin-Stars Thanks for the contribution. Left two minor comments.
|
|
||
| let mode = match request.mode.as_deref() { | ||
| Some(m) if m.eq_ignore_ascii_case("overwrite") => lance::dataset::WriteMode::Overwrite, | ||
| _ => lance::dataset::WriteMode::Append, |
There was a problem hiding this comment.
To be more seriously, we may need to enumale the mode more carefully. For example, if it is not append, we need to throw an exception?
| .nearest( | ||
| request.vector_column.as_deref().unwrap_or("vector"), | ||
| &query_array, | ||
| request.k as usize, |
There was a problem hiding this comment.
Check the k arg? Should it be larger than 0?
60c499c to
1a2e984
Compare
1a2e984 to
9c8f82b
Compare
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
accf0ad to
591b3e0
Compare
…oryNamespace Implement three new table operation methods on DirectoryNamespace: - count_table_rows: count rows with optional version checkout and predicate filter - insert_into_table: write Arrow IPC batches in append or overwrite mode - query_table: vector similarity search or plain scan with filter/limit/offset/version Add lance-linalg as a dependency for DistanceType in vector search. Include 8 unit tests covering all new methods and edge cases.
fa88856 to
61605a3
Compare
jackye1995
left a comment
There was a problem hiding this comment.
thanks for the work, I added the missing bindings all the way up
close #6111
count_table_rowswith optional version checkout and predicate filterinsert_into_tablewith append/overwrite modes via Arrow IPCquery_tablesupporting vector similarity search (with distance type, nprobes, refine factor, prefilter) and plain scan with filter/limit/offset/versionlance-linalgdependency forDistanceTypein vector searchTest plan
cargo test -p lance-namespace-implspasses all new tests