Skip to content

fix: quote column names in merge_insert join to preserve case sensiti… #6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YSBF wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: quote column names in merge_insert join to preserve case sensiti… #6397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions rust/lance/src/dataset/write/merge_insert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,17 +790,21 @@ impl MergeInsertJob {
let session_ctx = SessionContext::new_with_config(session_config);
let schema = source.schema();
let new_data = session_ctx.read_one_shot(source)?;
// Quote column names to preserve case sensitivity — DataFusion's
// DataFrame::join() lowercases unquoted identifiers, which breaks
// merge_insert when column names contain uppercase letters (e.g. "Stock").
let join_cols = self
.params
.on // columns to join on
.on
.iter()
.map(|c| c.as_str())
.collect::<Vec<_>>(); // vector of strings of col names to join
.map(|c| format!("\"{}\"", c))
.collect::<Vec<_>>();
let join_cols = join_cols.iter().map(|s| s.as_str()).collect::<Vec<_>>();
let target_cols = self
.params
.on
.iter()
.map(|c| format!("target_{}", c))
.map(|c| format!("\"target_{}\"", c))
.collect::<Vec<_>>();
let target_cols = target_cols.iter().map(|s| s.as_str()).collect::<Vec<_>>();

Expand Down
Loading