Add PR template with requirements checklist#36
Open
Copilot wants to merge 2 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/landro/platform-engineering/sessions/f87d5c5c-2daa-4047-81ec-d1ea96ceac50 Co-authored-by: landro <45769+landro@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
landro
May 11, 2026 06:52
View session
landro
approved these changes
May 11, 2026
There was a problem hiding this comment.
Pull request overview
Adds a GitHub pull request template to standardise PR descriptions and ensure contributors explicitly confirm key project requirements (British English, security review, accessibility checks, screenshots).
Changes:
- Introduces
.github/pull_request_template.mdwith a structured summary section. - Adds a requirements checklist covering language, security (OWASP Top 10), accessibility (WCAG 2.2 AA), and screenshots.
Comment on lines
+21
to
+23
| <!-- Required for any visual change. Do NOT commit screenshots to the repository. --> | ||
| - [ ] Desktop viewport screenshot included below | ||
| - [ ] Mobile viewport screenshot included below |
Owner
There was a problem hiding this comment.
@copilot add a non visual change to requirements files to align
Contributor
Author
There was a problem hiding this comment.
Done in 9679224. The conditional wording is removed — screenshots are now required for every PR. Non-visual changes (docs, config, etc.) must tick the checkbox and write "N/A – no visual change" in the placeholder rather than silently omitting the section.
…changes Agent-Logs-Url: https://github.com/landro/platform-engineering/sessions/d0769bde-7590-4299-9c5d-15de01b7c911 Co-authored-by: landro <45769+landro@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.github/pull_request_template.mdso every PR is pre-filled with checkboxes covering the requirements defined incopilot-instructions.md/AGENTS.md— preventing agents and humans alike from silently skipping them (screenshots, accessibility, security, British English).Screenshots are now required for every PR. Non-visual changes (e.g. docs, config) must explicitly tick the checkbox and write "N/A – no visual change" in the placeholder, ensuring the requirement is never silently skipped.
Checklist
Language
Security
eval, unsafe DOM manipulation, or exposed secrets introducedAccessibility (WCAG 2.2 AA)
<nav>,<main>,<article>, etc.) with ARIA roles where neededalttext added to all imagesScreenshots
Desktop
N/A – no visual change
Mobile
N/A – no visual change