Merged
Conversation
Collaborator
Author
|
@jonahm-LANL I'm going to leave it to you guys if you want to document this or replace other indexers in the code with this one |
Yurlungur
approved these changes
Oct 29, 2025
Collaborator
Yurlungur
left a comment
There was a problem hiding this comment.
Looks good. I think lets get this in now and we can re-use it elsewhere later if we want to.
Collaborator
Author
|
I'll run the gitlab tests just to be sure and then merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This MR extracts the
GenericIndexerthat I created in #526 into its own MR.I would like to use this capability for the EAP integration effort so that I have a bit more flexibility with allocating lambda arrays when compared to the
CacheAccessorthat already exists with the closure models. That class hard codes the number of lambdas, whereas I'd like that to be something I can set.PR Checklist
make formatcommand after configuring withcmake.If preparing for a new release, in addition please check the following:
when='@main'dependencies are updated to the release version in the package.py