docs(lark-wiki): correct the --as default-identity claim#919
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughWalkthroughDocumentation-only changes: added a "身份选择" guideline in ChangesIdentity Resolution Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 65.92% 65.92%
=======================================
Files 523 523
Lines 49692 49692
=======================================
Hits 32758 32758
Misses 14134 14134
Partials 2800 2800 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@d5cdb55783fe88f77a48ab9d1dfb6c71ed8067df🧩 Skill updatenpx skills add larksuite/cli#fix/wiki-skill-default-identity -y -g |
The skill doc claimed wiki list/copy shortcuts default to --as user, but the CLI --as default is `auto` (no --as commonly resolves to bot, listing the app's spaces instead of the user's). Running `wiki +space-list` without --as therefore returns app-scoped data, contradicting the doc. Following the established lark-mail convention (concise user-centric guidance, not a precedence essay): - add a short "优先使用 user 身份" section to SKILL.md - fix the --as rows in lark-wiki-space-list / node-list / node-copy references to show the real `auto` default and steer to --as user Change-Id: I539f8d622c1bbad57f8a64c2fc7b7ecc0dfe2116
e01ab4b to
d5cdb55
Compare
Summary
Plan A fix for the reported
wiki +space-listidentity bug. Docs-only, branched offmain(independent of #904).The lark-wiki skill claimed list/copy shortcuts default to
--as user, but identity is resolved by the global precedence —--as> strict-mode > appdefaultAs> auto-detect (which falls back tobot). Solark-cli wiki +space-listwithout--ascommonly resolves tobotand lists the app's spaces instead of the user's, contradicting the doc.This is a pre-existing framework-wide behavior (
internal/cmdutil/factory.goauto-detect fallback), not a regression — the fix here is to make the docs match reality and steer the agent to pass--as userfor wiki's user-centric operations. (No code change; the framework precedence is intentionally global and out of scope.)Changes
SKILL.md: new authoritative 身份解析(必读) section — spells out the real precedence, thebotfallback, and the rule to pass--as userfor query/list/read/my_libraryoperations.references/lark-wiki-space-list.md,lark-wiki-node-list.md,lark-wiki-node-copy.md: corrected the--asrows to stop advertising a non-existentuserdefault.Test plan
node scripts/skill-format-check/index.js— passed (CI skill gate)./scripts/skill-format-check/test.sh— all passedgo build ./...OK,go test ./shortcuts/wiki/...green (sanity; no code touched)skills/lark-wiki/Summary by CodeRabbit
--asflag selects identity (auto/user/bot)--asdefaults toauto(notuser) and explain resolution behavior--as userfor user-centric wiki operations; notemy_libraryrequires--as user