feat!: Update StreamingDataSourceBuilder to require HttpTransport #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
commented
Jan 7, 2026
| pub async fn new( | ||
| create_instance_params: CreateInstanceParams, | ||
| connector: HttpsConnector, | ||
| streaming_https_connector: StreamingHttpsConnector, |
Member
Author
There was a problem hiding this comment.
The event source and the SDK both relied on hyper pre-1.0. Since the SDK still relies on it, we have a couple of different types we have to juggle. As a result, we have our connector, and then our streaming specific connector.
I plan on updating the hyper usage for the rest of the library next, which should remove this silliness. But it's needed for now.
| type HttpsConnector = hyper_tls::HttpsConnector<HttpConnector>; | ||
| #[cfg(feature = "tls")] | ||
| type StreamingHttpsConnector = | ||
| hyper1_tls::HttpsConnector<hyper_util::client::legacy::connect::HttpConnector>; |
Member
Author
There was a problem hiding this comment.
Note the 1 in hyper1_tls.
| hyper = { version = "0.14.19", features = ["client"] } | ||
| hyper-rustls = { version = "0.24.1" , optional = true, features = ["http2"]} | ||
| hyper-tls = { version = "0.5.0", optional = true } | ||
| hyper1-tls = { package = "hyper-tls", version = "0.6.0", optional = true } |
Member
Author
There was a problem hiding this comment.
@kinyoklion turns out you can specify which version you want based on a feature, and this is me doing it. 😄
| data-encoding = "2.3.2" | ||
| eventsource-client = { version = "0.16.0", default-features = false } | ||
| # eventsource-client = { version = "0.16.0", default-features = false } | ||
| eventsource-client = { git = "https://github.com/launchdarkly/rust-eventsource-client", branch = "mk/sdk-1726/hyper-transport" } |
Member
Author
There was a problem hiding this comment.
Will update these once we decide everything is good enough to cut a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.