🦺 Embrace singleton behavior & remove the footgun#32
Merged
zeenix merged 2 commits intolayerx-world:mainfrom Mar 25, 2026
Merged
🦺 Embrace singleton behavior & remove the footgun#32zeenix merged 2 commits intolayerx-world:mainfrom
zeenix merged 2 commits intolayerx-world:mainfrom
Conversation
Currently if the user accidentally (people don't read docs) launch multiple instances of a controller, they'll end up having strange issue and have no idea what is going on. Given that singletons are normal for actors and embassy_sync's channels are designed to be used as static variables, let's just embrace singletons, but ensure that no 2 instances of a controller can be created by returning an `Option<Self>` from the generated `new` method, which only returns `Some` the first time it's called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the user accidentally (people don't read docs) launch multiple instances of a controller, they'll end up having strange issue and have no idea what is going on.
Given that singletons are normal for actors and embassy_sync's channels are designed to be used as static variables, let's just embrace singletons, but ensure that no 2 instances of a controller can be created by returning an
Option<Self>from the generatednewmethod, which only returnsSomethe first time it's called.