Skip to content

Fix intermediate integer overflow in math.lcm and math.hypot #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ekMartian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix intermediate integer overflow in math.lcm and math.hypot #2881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/runtime/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,9 +498,9 @@ def lcm(a: i32, b: i32) -> i32:
a_ = -a_
if b_ < 0:
b_ = -b_
if a_*b_ == 0:
if a_ == 0 or b_ == 0:
return 0
return i32((a_*b_)//gcd(a_, b_))
return i32((a_ // gcd(a_, b_)) * b_)


def copysign(x: f64, y: f64) -> f64:
Expand All @@ -517,7 +517,11 @@ def hypot(x: i32, y: i32) -> f64:
"""
Returns the hypotenuse of the right triangle with sides `x` and `y`.
"""
return sqrt(f64(1.0)*f64(x**2 + y**2))
xf: f64
yf: f64
xf = f64(x)
yf = f64(y)
return sqrt(xf**2.0 + yf**2.0)

@overload
def trunc(x: f64) -> i64:
Expand Down
Loading