Add pre semantics plugin hook#5127
Open
ljmf00-wekaio wants to merge 2 commits into
Open
Conversation
Signed-off-by: Luis Ferreira <luis.ferreira@weka.io>
…st semantic interfaces Signed-off-by: Luis Ferreira <luis.ferreira@weka.io>
| for (auto &plugin : sema_plugins) { | ||
| assert(plugin.runSemanticAnalysis); | ||
| plugin.runSemanticAnalysis(m); | ||
| if (plugin.runSemanticAnalysis) |
Member
There was a problem hiding this comment.
nitpick: cleaner to early exit when this is null?
Author
There was a problem hiding this comment.
The idea here is to optionally require those functions in the plugin, as now we have multiple of them, but I guess we can keep the old behavior and only make runPreSemanticAnalysis optional.
What if a user only wants to have a plugin for runPreSemanticAnalysis? I can check for both in both places (if they have at least one).
Member
There was a problem hiding this comment.
That's not what i meant. I agree with the change that both are optional.
I just meant hoisting the if-statement out of the loop :)
Member
|
It's a good addition I think, although it is a workaround around a fundamental frontend issue (information loss after sema). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like
runSemanticAnalysis, we should have something likerunPreSemanticAnalysis. One of the motivations for this is to help referencing AST nodes that represent user code that was deleted by semantics, e.g. constant folding.CC @JohanEngelen