ldc-build-runtime: require absolute --buildDir for --reset#5128
Open
ramen-bully wants to merge 1 commit into
Open
ldc-build-runtime: require absolute --buildDir for --reset#5128ramen-bully wants to merge 1 commit into
ramen-bully wants to merge 1 commit into
Conversation
When --reset / --resetOnly is passed and --buildDir is a relative path (including the default `ldc-build-runtime.tmp`), the deletion loop resolves the path against the current working directory at the moment the tool runs. If that CWD happens to be a project root — for example `ldc-build-runtime --buildDir=. --reset` invoked from the project — the loop iterates the project's top-level entries and removes every file plus every subdirectory not literally named `ldc-src`. This has destroyed working repositories. Refuse to proceed when --reset is requested with a relative --buildDir, and resolve the path to absolute before any deletion runs. Builds without --reset continue to accept relative paths unchanged (no deletion happens, so no destruction risk).
Member
|
Hmm, I think this is perfectly fine when e.g. not specifying a build dir explicitly, so using the pretty safe relative |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disclaimer i used AI.
When --reset / --resetOnly is passed and --buildDir is a relative path (including the default
ldc-build-runtime.tmp), the deletion loop resolves the path against the current working directory at the moment the tool runs. If that CWD happens to be a project root — for exampleldc-build-runtime --buildDir=. --resetinvoked from the project — the loop iterates the project's top-level entries and removes every file plus every subdirectory not literally namedldc-src. This has destroyed working repositories.Refuse to proceed when --reset is requested with a relative --buildDir, and resolve the path to absolute before any deletion runs. Builds without --reset continue to accept relative paths unchanged (no deletion happens, so no destruction risk).
note - i got burned pretty badly by this...