fix(section_list): add spinlock for free list and fix use-after-unmap #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
detach_article_block_shm()Changes
Race Condition Fix (Free List)
Added
pthread_spinlock_t free_list_spinlockto protect concurrent access to the article block free list:p_block_free_list, unlock afterp_block_free_list, unlock afterSpinlock is chosen over mutex because:
Use-After-Unmap Fix
In
detach_article_block_shm(), the code was accessingp_article_block_pool->shm_countandp_article_block_pool->shm_sizeafter potentially unmapping memory. Fixed by:shm_countandshm_sizeto local variables before any unmap operationsLifecycle Management
article_block_init()detach_article_block_shm()Test Plan
🤖 Generated with Claude Code