fix(section_list): fix binary search overflow and linked list boundary#88
Merged
leafok88 merged 2 commits intoleafok:mainfrom Jan 7, 2026
Merged
Conversation
- Fix integer overflow in binary search by using safe formula: `mid = left + (right - left) / 2` instead of `(left + right) / 2` - Fix linked list removal in section_list_move_topic() to handle single-element list correctly by checking if list becomes empty before updating neighbor pointers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
leafok88
approved these changes
Jan 7, 2026
leafok88
added a commit
that referenced
this pull request
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Binary Search Integer Overflow Fix
Changed the mid-point calculation formula in three binary search locations to prevent integer overflow:
Before (vulnerable to overflow):
After (safe):
Affected functions:
article_block_find_by_aid()- two binary search loopssection_list_find_article_with_offset()- one binary search loopLinked List Boundary Condition Fix
In
section_list_move_topic(), when removing an article from a single-element list:Before (bug):
After (fixed):
Test Plan
🤖 Generated with Claude Code