Expose connectionStateStream in pipe_client #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for exposing connection state changes as a Stream in the PipeClient by implementing a state change stream in the underlying HubConnection class.
Key Changes:
- Added a
StreamControllertoHubConnectionto track and broadcast connection state changes - Introduced an
updateConnectionStatemethod that updates both the internal state and emits to the stream - Exposed the connection state stream through both
HubConnectionandPipeClientpublic APIs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| dart/lib/signalr_core/src/hub_connection.dart | Implements connection state streaming by adding a StreamController, replacing direct state assignments with updateConnectionState calls, and exposing the stream via a public getter |
| dart/lib/leancode_pipe/pipe_client.dart | Exposes the connection state stream by mapping HubConnection states to PipeConnectionStates and providing a public getter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PiotrRogulski
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.