-
Notifications
You must be signed in to change notification settings - Fork 0
Support configuring SignalR and use CQRS JSON serialization options by default #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary
🎉 No failed tests in this run. | ⏭️ No skipped tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 90.09% 91.43% +1.34%
==========================================
Files 34 34
Lines 747 759 +12
Branches 46 48 +2
==========================================
+ Hits 673 694 +21
+ Misses 71 62 -9
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for configuring SignalR options and applies CQRS JSON serialization settings by default. The changes introduce new optional parameters for customizing both the JSON serialization protocol and hub-specific options across all LeanPipe variants (standard, funnelled, and funnel instance).
- Introduces a new extension method
ConfigureForCQRS()that applies CQRS-specific JSON converters and naming policies - Adds optional parameters to configure
HubOptionsand overrideJsonHubProtocolOptionsin all LeanPipe registration methods - Provides comprehensive test coverage for the new configuration options
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
publisher/src/LeanCode.Pipe/Extensions/CQRSJsonSerializerOptionsExtensions.cs |
New extension method for applying CQRS JSON serialization configuration |
publisher/src/LeanCode.Pipe/Extensions/LeanPipeServiceCollectionExtensions.cs |
Updated to support configurable SignalR hub options and JSON protocol options |
publisher/src/Funnel/Publishing/ServiceCollectionExtensions.cs |
Added parameter to override JSON hub protocol options in funnelled variant |
publisher/src/Funnel/Instance/ServiceCollectionExtensions.cs |
Added parameters for hub configuration and JSON protocol override in funnel instance |
publisher/src/LeanCode.Pipe/LeanCode.Pipe.csproj |
Added dependency on LeanCode.Serialization package |
publisher/Directory.Packages.props |
Added version management for LeanCode.Serialization package |
publisher/test/LeanCode.Pipe.Tests/LeanPipeServiceCollectionExtensionsTests.cs |
Added tests for default and overridden serialization configuration, plus hub options |
publisher/test/Funnel.Tests/LeanCode.Pipe.Funnel.Tests/Publishing/ServiceCollectionExtensionsTests.cs |
Reorganized and added tests for serialization configuration in funnelled variant |
publisher/test/Funnel.Tests/LeanCode.Pipe.Funnel.Tests/Instance/ServiceCollectionExtensionsTests.cs |
New test file for funnel instance configuration testing with serialization and hub options tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
publisher/src/LeanCode.Pipe/Extensions/CQRSJsonSerializerOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
publisher/src/LeanCode.Pipe/Extensions/CQRSJsonSerializerOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
publisher/src/LeanCode.Pipe/Extensions/LeanPipeServiceCollectionExtensions.cs
Show resolved
Hide resolved
|
Draft, because we'd like to use CQRS JSON serialization options config straight from the corelib, once they are exposed: leancodepl/corelibrary#816 |
Closes CORELIB-210