Skip to content

Conversation

@Dragemil
Copy link
Collaborator

@Dragemil Dragemil commented Jan 2, 2026

Closes CORELIB-210

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
81 81 0 0 0 0 18.1s

🎉 No failed tests in this run. | ⏭️ No skipped tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.43%. Comparing base (b59b298) to head (ef4e9f6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   90.09%   91.43%   +1.34%     
==========================================
  Files          34       34              
  Lines         747      759      +12     
  Branches       46       48       +2     
==========================================
+ Hits          673      694      +21     
+ Misses         71       62       -9     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for configuring SignalR options and applies CQRS JSON serialization settings by default. The changes introduce new optional parameters for customizing both the JSON serialization protocol and hub-specific options across all LeanPipe variants (standard, funnelled, and funnel instance).

  • Introduces a new extension method ConfigureForCQRS() that applies CQRS-specific JSON converters and naming policies
  • Adds optional parameters to configure HubOptions and override JsonHubProtocolOptions in all LeanPipe registration methods
  • Provides comprehensive test coverage for the new configuration options

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
publisher/src/LeanCode.Pipe/Extensions/CQRSJsonSerializerOptionsExtensions.cs New extension method for applying CQRS JSON serialization configuration
publisher/src/LeanCode.Pipe/Extensions/LeanPipeServiceCollectionExtensions.cs Updated to support configurable SignalR hub options and JSON protocol options
publisher/src/Funnel/Publishing/ServiceCollectionExtensions.cs Added parameter to override JSON hub protocol options in funnelled variant
publisher/src/Funnel/Instance/ServiceCollectionExtensions.cs Added parameters for hub configuration and JSON protocol override in funnel instance
publisher/src/LeanCode.Pipe/LeanCode.Pipe.csproj Added dependency on LeanCode.Serialization package
publisher/Directory.Packages.props Added version management for LeanCode.Serialization package
publisher/test/LeanCode.Pipe.Tests/LeanPipeServiceCollectionExtensionsTests.cs Added tests for default and overridden serialization configuration, plus hub options
publisher/test/Funnel.Tests/LeanCode.Pipe.Funnel.Tests/Publishing/ServiceCollectionExtensionsTests.cs Reorganized and added tests for serialization configuration in funnelled variant
publisher/test/Funnel.Tests/LeanCode.Pipe.Funnel.Tests/Instance/ServiceCollectionExtensionsTests.cs New test file for funnel instance configuration testing with serialization and hub options tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Dragemil
Copy link
Collaborator Author

Dragemil commented Jan 2, 2026

Draft, because we'd like to use CQRS JSON serialization options config straight from the corelib, once they are exposed: leancodepl/corelibrary#816

@Dragemil Dragemil marked this pull request as ready for review January 5, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants