feat(LinearAlgebra/Basis/HasCanonicalBasis): propose HasCanonicalBasis class#25425
Closed
Paul-Lez wants to merge 4 commits into
Closed
feat(LinearAlgebra/Basis/HasCanonicalBasis): propose HasCanonicalBasis class#25425Paul-Lez wants to merge 4 commits into
HasCanonicalBasis class#25425Paul-Lez wants to merge 4 commits into
Conversation
1 task
PR summary c6a8ffddfeImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Collaborator
|
This pull request has conflicts, please merge |
Collaborator
Author
|
This PR has been migrated to a fork-based workflow: #39253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: in some cases, e.g. writing down PDEs, having a notion of partial derivatives can be useful. In an ideal world (as mentioned by @ocfnash in this Zulip thread), one could write something along the lines of
open scoped PartialDerivativesin order to access nice notation for this.This PR introduces a notion of a canonical basis for a module in order to allow taking partial derivatives with respect to it.
A later PR (which I am about open) would then propose a notation for taking partial derivatives (defined using
lineDerivin order to avoid requiring Frechet-differentiability assumptions). The goal here is to have notation that works equally well on e.g.𝕜 × 𝕜andEuclideanSpace 𝕜 (Fin 2)and so on.I've opened this PR as a draft in order to get some initial feedback on the content (and whether this is considered appropriate for Mathlib!); the file itself would need to be split (e.g. the instances defined should probably go in different files)
Co-authored-by: Eric Wieser efw@google.com