feat: check indentation in doc-strings, medium version#27996
Closed
grunweg wants to merge 49 commits into
Closed
Conversation
because a paragraph break has (small) semantic meaning: please double-check!
There is no need for five or four when two will do equally well. This also avoids warnings from the linter in ... Arguably, these could be wrapped in code blocks instead. Should they?
This reverts commit fad1a60.
github-actions
Bot
removed
the
merge-conflict
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Aug 11, 2025
Found by the linter in #27996.
mathlib4-merge-conflict-bot
added
the
merge-conflict
Collaborator
|
This pull request has conflicts, please merge |
github-actions
Bot
removed
the
merge-conflict
mathlib4-merge-conflict-bot
added
the
merge-conflict
Collaborator
|
This pull request has conflicts, please merge |
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…le guide (leanprover-community#28002) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…de (leanprover-community#28003) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…r-community#28004) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…r-community#28006) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…trings to match the style guide (leanprover-community#28007) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…r-community#28005) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…r-community#28041) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…le guide (leanprover-community#28002) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…de (leanprover-community#28003) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…r-community#28004) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…r-community#28006) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…trings to match the style guide (leanprover-community#28007) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…r-community#28005) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…r-community#28041) The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
The style guide asks for subsequent lines in doc-strings to not be indented ([zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Style.20.3Abicycle.3A.20.3A.20indenting.20second.20lines.20in.20doc-strings/with/513186492)). This fixes some violations. Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
Found by the linter in leanprover-community#27996.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
Found by the linter in leanprover-community#27996.
Contributor
Author
|
Let's close this PR and re-do the fixes on current master, instead of painstakingly trying to rebase everything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.