Skip to content

[Merged by Bors] - feat(Geometry/Euclidean): add converse of Thales' theorem in 2D#34149

Closed
Scarlett-le wants to merge 2 commits intoleanprover-community:masterfrom
Scarlett-le:feat/thales-converse-2d
Closed

[Merged by Bors] - feat(Geometry/Euclidean): add converse of Thales' theorem in 2D#34149
Scarlett-le wants to merge 2 commits intoleanprover-community:masterfrom
Scarlett-le:feat/thales-converse-2d

Conversation

@Scarlett-le
Copy link
Copy Markdown
Contributor

Add Sphere.isDiameter_of_angle_eq_pi_div_two: if three distinct
points on a circle in 2D form a right angle, then the chord through
the endpoints is a diameter.

@github-actions github-actions Bot added the t-euclidean-geometry Affine and axiomatic geometry label Jan 19, 2026
@github-actions
Copy link
Copy Markdown

PR summary fadadaad32

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ isDiameter_of_angle_eq_pi_div_two

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@jsm28
Copy link
Copy Markdown
Contributor

jsm28 commented Jan 25, 2026

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by jsm28.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 25, 2026
@bryangingechen
Copy link
Copy Markdown
Contributor

Thanks!
bors r+

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 29, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jan 29, 2026
Add `Sphere.isDiameter_of_angle_eq_pi_div_two`: if three distinct
points on a circle in 2D form a right angle, then the chord through
the endpoints is a diameter.

Co-authored-by: Scarlett-le <735979178@qq.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Jan 29, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(Geometry/Euclidean): add converse of Thales' theorem in 2D [Merged by Bors] - feat(Geometry/Euclidean): add converse of Thales' theorem in 2D Jan 29, 2026
@mathlib-bors mathlib-bors Bot closed this Jan 29, 2026
YellPika pushed a commit to YellPika/mathlib4 that referenced this pull request Feb 3, 2026
…prover-community#34149)

Add `Sphere.isDiameter_of_angle_eq_pi_div_two`: if three distinct
points on a circle in 2D form a right angle, then the chord through
the endpoints is a diameter.

Co-authored-by: Scarlett-le <735979178@qq.com>
Maldooor pushed a commit to Maldooor/mathlib4 that referenced this pull request Feb 25, 2026
…prover-community#34149)

Add `Sphere.isDiameter_of_angle_eq_pi_div_two`: if three distinct
points on a circle in 2D form a right angle, then the chord through
the endpoints is a diameter.

Co-authored-by: Scarlett-le <735979178@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-euclidean-geometry Affine and axiomatic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants