[Merged by Bors] - refactor(QuadraticForm/Complex): generalize to algebraically closed field#34158
Closed
wwylele wants to merge 7 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - refactor(QuadraticForm/Complex): generalize to algebraically closed field#34158wwylele wants to merge 7 commits intoleanprover-community:masterfrom
wwylele wants to merge 7 commits intoleanprover-community:masterfrom
Conversation
github-actions
Bot
added
large-import
PR summary 57d8fb21ebImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.LinearAlgebra.QuadraticForm.Complex | 1949 | 2581 | +632 (+32.43%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.LinearAlgebra.QuadraticForm.Complex |
632 |
Mathlib.LinearAlgebra.QuadraticForm.AlgClosed (new file) |
1706 |
Declarations diff
+ equivalent_of_isAlgClosed
+ equivalent_weightedSumSquares_of_isAlgClosed
+ isometryEquivWeightedSumSquaresWeightedSumSquares
+ weightedSumSquaresCongr
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for scripts/declarations_diff.sh contains some details about this script.
Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
| Current number | Change | Type |
|---|---|---|
| 629 | -1 | erw |
Current commit 5cc6bee749
Reference commit 57d8fb21eb
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
erdOne
reviewed
Jan 21, 2026
| /-- The isometry between a weighted sum of squares on an algebraically closed field and the | ||
| sum of squares, i.e. `weightedSumSquares` with weights 1 or 0. -/ | ||
| noncomputable def isometryEquivSumSquares [DecidableEq K] (w' : ι → K) : | ||
| IsometryEquiv (weightedSumSquares K w') |
Member
There was a problem hiding this comment.
I think you should generalize this to "weightedSumSquares w equiv weightedSumSquares w'" if w/w' is a square of a unit.
Collaborator
Author
There was a problem hiding this comment.
Thanks for the suggestion! I have implemented this as isometryEquivWeightedSumSquares₂. Do you know if we already have the bundled version of the LinearEquiv part of this def? I have found LinearEquiv.smulOfUnit and DistribMulAction.toLinearEquiv but I couldn't make them type check
wwylele
force-pushed
the
quadform-alg-closed
branch
from
739ec12 to
223d502
Compare
…ield A free generalization since the only place the property of C is used is to get a square root. This can still be further generalized to quadratically closed field, but we don't have that definition yet. Also did small clean up and removed a erw.
wwylele
force-pushed
the
quadform-alg-closed
branch
from
223d502 to
9a584f4
Compare
erdOne
reviewed
Jan 22, 2026
erdOne
reviewed
Jan 22, 2026
wwylele
force-pushed
the
quadform-alg-closed
branch
from
ac43de4 to
d5b2e2c
Compare
Contributor
|
Unassigning myself as I am travelling without laptop for the next 9 days. |
chrisflav
reviewed
Feb 16, 2026
chrisflav
added
the
awaiting-author
chrisflav
reviewed
Feb 16, 2026
wwylele
removed
the
awaiting-author
chrisflav
reviewed
Feb 19, 2026
chrisflav
added
the
awaiting-author
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
wwylele
removed
the
awaiting-author
|
🚀 Pull request has been placed on the maintainer queue by chrisflav. |
mathlib-triage
Bot
added
the
maintainer-merge
Member
|
Thanks! bors merge |
mathlib-triage
Bot
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
…ield (#34158) A free generalization since the only place the property of C is used is to get a square root. This can still be further generalized to quadratically closed field, but we don't have that definition yet. Also did small clean up and removed a erw.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Mar 2, 2026
…ield (leanprover-community#34158) A free generalization since the only place the property of C is used is to get a square root. This can still be further generalized to quadratically closed field, but we don't have that definition yet. Also did small clean up and removed a erw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A free generalization since the only place the property of C is used is to get a square root. This can still be further generalized to quadratically closed field, but we don't have that definition yet.
Also did small clean up and removed a erw.