feat(NumberTheory/ModularForms): API lemmas for level-1 graded ring#38908
Draft
CBirkbeck wants to merge 3 commits into
Draft
feat(NumberTheory/ModularForms): API lemmas for level-1 graded ring#38908CBirkbeck wants to merge 3 commits into
CBirkbeck wants to merge 3 commits into
Conversation
PR summary 834e51690b
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.NumberTheory.ModularForms.QExpansion | 2776 | 2782 | +6 (+0.22%) |
Import changes for all files
| Files | Import difference |
|---|---|
6 filesMathlib.NumberTheory.ModularForms.Bounds Mathlib.NumberTheory.ModularForms.LevelOne.Basic Mathlib.NumberTheory.ModularForms.LevelOne Mathlib.NumberTheory.ModularForms.NormTrace Mathlib.NumberTheory.ModularForms.Petersson Mathlib.NumberTheory.ModularForms.QExpansion |
6 |
Declarations diff
+ cast_apply
+ mul_ne_zero
+ of_eq_of_eq
+ of_eq_sub_add_smul
+ sub_smul_isCuspForm
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
No changes to strong technical debt.
No changes to weak technical debt.
2 tasks
…aded ring Adds five lemmas extracted from the upcoming graded-ring PR (leanprover-community#38813), so that that PR can be reviewed in smaller pieces: * `DirectSum.of_eq_of_eq` (Algebra/DirectSum/Basic): cast indices in `of`. * `DirectSum.of_eq_sub_add_smul` (Algebra/DirectSum/Module): the identity `of i f = of i (f - c•g) + c • of i g`. * `ModularForm.cast_apply` (NumberTheory/ModularForms/Basic): a ModularForm cast through a weight equality has the same pointwise values. * `ModularForm.mul_ne_zero` (NumberTheory/ModularForms/QExpansion): the product of two non-zero modular forms is non-zero (via integral domain structure of `PowerSeries ℂ`). * `ModularForm.sub_smul_isCuspForm` (NumberTheory/ModularForms/CuspFormSubmodule): for level-1 forms `f, g` with `(qExpansion 1 g).coeff 0 = 1`, the form `f - (qExpansion 1 f).coeff 0 • g` is a cusp form. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mathlib-dependent-issues
Bot
added
the
blocked-by-other-PR
CBirkbeck
force-pushed
the
modular-forms-api-prereq
branch
from
e920f0c to
f8d4551
Compare
mathlib-dependent-issues
Bot
removed
the
blocked-by-other-PR
CBirkbeck
added
the
LLM-generated
CBirkbeck
commented
May 11, 2026
| ModularForm.qExpansion_mul hh hΓ, mul_eq_zero, not_or] | ||
| exact ⟨(ModularForm.qExpansion_eq_zero_iff hh hΓ _).not.mpr hf, | ||
| (ModularForm.qExpansion_eq_zero_iff hh hΓ _).not.mpr hg⟩ | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
why the extra blank line?
mathlib-merge-conflicts
Bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
…-prereq # Conflicts: # Mathlib/NumberTheory/ModularForms/QExpansion.lean
github-actions
Bot
removed
the
merge-conflict
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds API lemmas extracted from #38813 to keep that PR reviewable:
DirectSum.of_eq_of_eq,DirectSum.of_eq_sub_add_smul,ModularForm.cast_apply,ModularForm.mul_ne_zero,ModularForm.sub_smul_isCuspForm.