Skip to content

feat(Tactic/FunProp): allow discharging non-prop hypotheses #39224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grunweg wants to merge 1 commit into from
+13 −11
Closed

feat(Tactic/FunProp): allow discharging non-prop hypotheses #39224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions Mathlib/Tactic/FunProp/Core.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,19 @@ def synthesizeArgs (thmId : Origin) (xs : Array Expr)
else
-- try user provided discharger
let ctx : Context ← read
if (← isProp type) then
if let some proof ← ctx.disch type then
if (← isDefEq x proof) then
continue
else do
trace[Meta.Tactic.fun_prop]
"{← ppOrigin thmId}, failed to assign proof{indentExpr type}"
return false
else
logError s!"Failed to prove necessary assumption `{← ppExpr type}` \
when applying theorem `{← ppOrigin' thmId}`."
-- we allow the discharger to both infer propositions (e.g., function properties)
-- and data arguments (e.g., models with corners for use with `ContMDiff` in the manifold
-- library)
if let some proof ← ctx.disch type then
if (← isDefEq x proof) then
continue
else do
trace[Meta.Tactic.fun_prop]
"{← ppOrigin thmId}, failed to assign proof{indentExpr type}"
return false
else
logError s!"Failed to prove necessary assumption `{← ppExpr type}` \
when applying theorem `{← ppOrigin' thmId}`."

if ¬(← isProp type) then
postponed := postponed.push x
Expand Down
Loading