Skip to content

feat(fun_prop): allow fun_prop to call discharger on ModelWithCorners#39226

Open
lecopivo wants to merge 4 commits into
leanprover-community:masterfrom
lecopivo:fun_prop_mdiff
Open

feat(fun_prop): allow fun_prop to call discharger on ModelWithCorners#39226
lecopivo wants to merge 4 commits into
leanprover-community:masterfrom
lecopivo:fun_prop_mdiff

Conversation

@lecopivo
Copy link
Copy Markdown
Collaborator

@lecopivo lecopivo commented May 11, 2026

Currently, a discharger in fun_prop is allowed to be run only on Prop-valued hypothesis.
This PR allows to execute dischargers also on ModelWithCorners. This will enable fun_prop to support ContMDiff properly: lemmas like ContMDiff.comp require inferring the model with corners on the intermediate space. This PR is thus required to properly support manifolds in fun_prop; a future PR will implement this.

In the future, we might want to allow the discharger to execute on other Type-valued hypothesis.
In this case, we could create an environment extension to register such types.
However, right now we could not think of any other use cases --- therefore, we hard-coded ModelWithCorners.


Open in Gitpod

@github-actions github-actions Bot added the t-meta Tactics, attributes or user commands label May 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

PR summary 1b6d405437

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Dummy
+ ModelWithCorners
+ ModelWithCorners.prod
+ apply
+ comp
+ const
+ fst
+ id
+ instance : Dummy A := ⟨⟩
+ mdiff_add
+ mdiff_mul
+ pi
+ prod_mk
+ snd

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@grunweg grunweg self-assigned this May 11, 2026
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented May 11, 2026

As we discussed in person: thanks a lot, this is great! Please add the test you created locally, once your local build has worked. (I should also make a prototype branch to hack in ContMDiff support; that's one me.)

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label May 11, 2026
@github-actions github-actions Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 11, 2026
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor style comments. (I like cleanly written comments.)

Comment thread MathlibTest/fun_prop_dev.lean
Comment thread MathlibTest/fun_prop_dev.lean Outdated
Comment thread MathlibTest/fun_prop_dev.lean Outdated
Comment thread MathlibTest/fun_prop_dev.lean Outdated
Comment thread MathlibTest/fun_prop_dev.lean Outdated
Comment thread MathlibTest/fun_prop_dev.lean Outdated
Comment thread Mathlib/Tactic/FunProp/Core.lean
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented May 12, 2026

Oh, it seems I just force-pushed your work away... let me fix that! (edit: done)

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants