Skip to content

chore: extract API from #38807 and golf#39230

Open
bryangingechen wants to merge 3 commits into
leanprover-community:masterfrom
bryangingechen:dirsupclosed-union-refactor
Open

chore: extract API from #38807 and golf#39230
bryangingechen wants to merge 3 commits into
leanprover-community:masterfrom
bryangingechen:dirsupclosed-union-refactor

Conversation

@bryangingechen
Copy link
Copy Markdown
Contributor

I wanted to understand why these two proofs in #38807 were long (and also play around more with the API in this corner of the library) so I walked through them with Claude Opus.

prepared with Claude code

@bryangingechen bryangingechen added the LLM-generated PRs with substantial input from LLMs - review accordingly label May 12, 2026
@bryangingechen bryangingechen requested review from b-mehta and vihdzp May 12, 2026 01:58
@github-actions github-actions Bot added the t-order Order theory label May 12, 2026
@github-actions
Copy link
Copy Markdown

PR summary 45f0cc9e9b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsCofinalFor.nonempty
+ IsLUB.of_isCofinalFor

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@vihdzp
Copy link
Copy Markdown
Collaborator

vihdzp commented May 12, 2026

Thanks for this! I suspected my proofs were more complicated than they needed to be. I'll take a closer look tomorrow morning.

Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I can't say I fully understand the new proofs but I can't find ways to golf them further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LLM-generated PRs with substantial input from LLMs - review accordingly t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants