Skip to content

chore(Tactic/StacksAttribute): add deprecated module#39259

Open
jcommelin wants to merge 2 commits into
leanprover-community:masterfrom
jcommelin:crossref-deprmod
Open

chore(Tactic/StacksAttribute): add deprecated module#39259
jcommelin wants to merge 2 commits into
leanprover-community:masterfrom
jcommelin:crossref-deprmod

Conversation

@jcommelin
Copy link
Copy Markdown
Member

@jcommelin jcommelin commented May 12, 2026 •
edited by grunweg
Loading

This PR adds Tactic/StacksAttribute.lean back as deprecated_module.

Open in Gitpod

jcommelin added 2 commits May 12, 2026 16:39
@jcommelin
chore(Tactic): move StacksAttribute to CrossRefAttribute
d77be52 
This PR moves StacksAttribute.lean to CrossRefAttribute.lean
both in Mathlib/Tactic/ and in MathlibTest/.

In the future, we can refactor the file to abstract over the type of
cross-references. Currently, cross-reference attributes are implemented
for the Stacks Project and Kerodon.
A good candidate for a future PR is to add an attribute for Wikidata
identifiers.
@jcommelin
chore(Tactic/StacksAttribute): add deprecated module
24a945e 
This PR adds `Tactic/StacksAttribute.lean` back as deprecated_module.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

PR summary 53f8a93a77

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Tactic.StacksAttribute 1
Mathlib.Tactic.CrossRefAttribute (new file) 54

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

No changes to strong technical debt.
No changes to weak technical debt.

note: file MathlibTest/StacksAttribute.lean` was renamed to `MathlibTest/CrossRefAttribute.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

@github-actions github-actions Bot added the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label May 12, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 12, 2026
@adomani
Copy link
Copy Markdown
Contributor

adomani commented May 12, 2026

Now that the other PR has been merged, this one can go in as well!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented May 12, 2026

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label May 12, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 12, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

mathlib-dependent-issues Bot commented May 12, 2026

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adomani adomani

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). file-removed A Lean module was (re)moved without a `deprecated_module` annotation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcommelin @adomani