Skip to content

chore(Algebra/Ring/CharZero): remove scoped in simp attributes#39262

Open
Paul-Lez wants to merge 1 commit into
leanprover-community:masterfrom
Paul-Lez:remove-scoped-simps
Open

chore(Algebra/Ring/CharZero): remove scoped in simp attributes#39262
Paul-Lez wants to merge 1 commit into
leanprover-community:masterfrom
Paul-Lez:remove-scoped-simps

Conversation

@Paul-Lez
Copy link
Copy Markdown
Collaborator


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary d9cff27ba7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label May 12, 2026
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you find which PR introduced these tags?

@Paul-Lez
Copy link
Copy Markdown
Collaborator Author

Can you find which PR introduced these tags?

I believe this PR: #15631.

@YaelDillies
Copy link
Copy Markdown
Contributor

Maybe undo your change and turn this PR into an addition of a comment explaining the scoping

@Paul-Lez
Copy link
Copy Markdown
Collaborator Author

Sounds good, will update this in a bit:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants