Skip to content

feat(QM): AddZeroClass for UnboundedOperator#999

Merged
jstoobysmith merged 5 commits intoleanprover-community:masterfrom
gloges:operators
Mar 21, 2026
Merged

feat(QM): AddZeroClass for UnboundedOperator#999
jstoobysmith merged 5 commits intoleanprover-community:masterfrom
gloges:operators

Conversation

@gloges
Copy link
Contributor

@gloges gloges commented Mar 20, 2026

  • Defines zero as the zero map with full domain.

  • Defines addition of unbounded operators, using two junk values:

    • When D(U1) ∩ D(U2) is not dense, use the zero with full domain.
    • When D(U1) ∩ D(U2) is dense but U1 + U2 is not closable, use the zero map on D(U1) ∩ D(U2).

    This second junk value will be needed so that smul distributes over addition in all cases. It ensures that c • (U1 + U2) = c • U1 + c • U2 holds for (c : ℂ) = 0 when D(U1) ∩ D(U2) is dense, since the RHS is the zero map on D(U1) ∩ D(U2) regardless of whether U1 + U2 is closable or not.

  • add_assoc proves associativity holds when no junk values are encountered

(cf. #957, #978)

@gloges
Copy link
Contributor Author

gloges commented Mar 20, 2026

t-quantum-mechanics

@gloges
Copy link
Contributor Author

gloges commented Mar 20, 2026

RFC

@github-actions github-actions bot added t-quantum-mechanics Quantum mechanics RFC Request for comment labels Mar 20, 2026
Copy link
Member

@jstoobysmith jstoobysmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mainly good to me. Couple of comments

@jstoobysmith
Copy link
Member

awaiting-author

@github-actions github-actions bot added the awaiting-author A reviewer has asked the author a question or requested changes label Mar 20, 2026
@gloges
Copy link
Contributor Author

gloges commented Mar 21, 2026

I realized that add_assoc could be generalized slightly; addition is associative when neither of the intermediate additions U1 + U2 and U2 + U3 is a junk value. The hypotheses should now be easier to supply, as they concern the two pairs separately.

@gloges
Copy link
Contributor Author

gloges commented Mar 21, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes label Mar 21, 2026
Copy link
Member

@jstoobysmith jstoobysmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - many thanks. Will merge shortly
ready-to-merge

@jstoobysmith
Copy link
Member

ready-to-merge

@jstoobysmith jstoobysmith added ready-to-merge This PR is approved and will be merged shortly and removed RFC Request for comment labels Mar 21, 2026
@jstoobysmith jstoobysmith merged commit e5eaf63 into leanprover-community:master Mar 21, 2026
6 checks passed
@gloges gloges deleted the operators branch March 21, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is approved and will be merged shortly t-quantum-mechanics Quantum mechanics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants