Skip to content

Fencepost error for dims #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ppotapov-aws merged 1 commit into from
Feb 19, 2026
Merged

Fencepost error for dims #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions KLR/Trace/ISA.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ def dimsFromPythonDefs (dims : Int) (d : Sum Int (List Int)) : Trace TensorSubDi
| .inl 1 => return .X
| .inl _ => throw "not a valid dim"
| .inr r => do
if r == [dims] then return .X
if r == [dims-1, dims] then return .XY
if r == [dims-2, dims-1, dims] then return .XYZ
if r == [dims-3, dims-2, dims-1, dims] then return .XYZW
if r == [dims-1] then return .X -- last dim, 2d+ case
if r == [dims-2, dims-1] then return .XY -- last 2 dims, 3d+ case
if r == [dims-3, dims-2, dims-1] then return .XYZ -- last 3 dims, 4d+ case
if r == [dims-4, dims-3, dims-2, dims-1] then return .XYZW -- last 4 dims, 5d case
throw "not a valid dim"

def getTransposeOps(op: Option (List Int)) : Trace TransposeOps :=
Expand Down
Loading