fix: reverse order of no_reorder dependency edges#605
Merged
kerrijoe-aws merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
kerrijoe-aws
requested review from
govereau,
jiancheng-aws,
joonwonc,
jtristan,
ppotapov-aws,
seanmcl,
waahm7 and
yongweiy
as code owners
govereau
reviewed
Feb 26, 2026
kerrijoe-aws
force-pushed
the
jk/edge-order
branch
from
72a7505 to
d127029
Compare
govereau
approved these changes
Feb 26, 2026
PR #604 altered the semantics of no_reorder so that instructions executing on distinct engines can still be scheduled in parallel. Unfortunately, it also reversed the order of dependency edges emitted by no_reorder. Downstream components interpret an edge (a, b) as 'b depends on a', not the other way around. Update to preserve existing convention, and ensure user-provided edges follow this convention as well.
kerrijoe-aws
force-pushed
the
jk/edge-order
branch
from
d127029 to
55b8d4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #604 altered the semantics of no_reorder so that instructions executing on distinct engines can still be scheduled in parallel. Unfortunately, it also reversed the order of dependency edges emitted by no_reorder.
Downstream components interpret an edge (a, b) as 'b depends on a', not the other way around. Update to preserve existing convention.