Feat(Cryptography): Signed Barrett reduction algorithm#523
Open
atrieu wants to merge 2 commits intoleanprover:mainfrom
Open
Feat(Cryptography): Signed Barrett reduction algorithm#523atrieu wants to merge 2 commits intoleanprover:mainfrom
atrieu wants to merge 2 commits intoleanprover:mainfrom
Conversation
eric-wieser
reviewed
Apr 30, 2026
eric-wieser
reviewed
Apr 30, 2026
|
|
||
| end Cslib.Crypto.Algorithms.BarrettReduction.Signed | ||
|
|
||
| section MLKEMExample |
Contributor
There was a problem hiding this comment.
This is polluting the namespace, but I think moving it to CslibTests/ should be sufficient to avoid. It probably belongs there anyways.
| def IsApprox (δ : ℚ) (α : ℚ → ℤ) : Prop := | ||
| ∀ (x: ℚ), |(x - α x)| ≤ δ | ||
|
|
||
| lemma round_isApprox : IsApprox (1/2) round := by |
Contributor
There was a problem hiding this comment.
This and IsApprox are dead code, but I'm guessing you plan to use them later?
| public import Mathlib.Data.Rat.Floor | ||
| public import Mathlib.Algebra.Order.Field.Rat | ||
| public import Mathlib.Algebra.Order.Round | ||
| import Mathlib.Tactic |
Contributor
There was a problem hiding this comment.
Try not to import this directly, Cslib.Init should have what you need and import directly otherwise.
| public import Mathlib.Algebra.Order.Floor.Defs | ||
| public import Mathlib.Data.Int.DivMod | ||
| import Mathlib.Tactic | ||
|
|
Contributor
There was a problem hiding this comment.
This file should have a note to upstream most of its contents to mathlib I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a formalisation of the signed variant of the Barrett reduction algorithm which is used in recent crypto schemes such as ML-KEM and ML-DSA.