chore: inline trace nodes#11954
Merged
Kha merged 2 commits intoleanprover:masterfrom Jan 26, 2026
Merged
Conversation
Member
|
!bench |
|
Benchmark results for 5b9e69e against e766839 are in! @Kha @eric-wieser Runs (2🟥)
|
5b9e69e to
663d1e7
Compare
Member
|
!bench |
|
Benchmark results for 663d1e7 against e766839 are in! @Kha Large changes (4🟥)
Medium changes (6✅, 22🟥)Too many entries to display here. View the full report on radar instead. Small changes (211✅, 32🟥)Too many entries to display here. View the full report on radar instead. |
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Member
|
!bench mathlib |
|
Benchmark results for leanprover-community/mathlib4-nightly-testing@0022380 against leanprover-community/mathlib4-nightly-testing@7c43efe are in! @Kha No significant changes detected. |
This extracts a `postCallback` helper so that only the actual callback is inlined.
663d1e7 to
0bfb4b6
Compare
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 11, 2026
ghost
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 11, 2026
Kha
reviewed
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts a
postCallbackhelper so that only the actual callback is inlined.Part of the motivation here is to exclude these tracing frames from flame graph profiles.