Skip to content

feat: upstream unusedDecidableInType linter#13688

Open
wkrozowski wants to merge 39 commits into
leanprover:masterfrom
wkrozowski:wojciech/unusedDecidableInType
Open

feat: upstream unusedDecidableInType linter#13688
wkrozowski wants to merge 39 commits into
leanprover:masterfrom
wkrozowski:wojciech/unusedDecidableInType

Conversation

@wkrozowski
Copy link
Copy Markdown
Contributor

@wkrozowski wkrozowski commented May 8, 2026

This PR upstreams unusedDecidableInType linter from mathlib.

Stacked on top of #11313.

thorimur and others added 30 commits April 23, 2026 15:03
@wkrozowski wkrozowski added the changelog-no Do not include this PR in the release changelog label May 8, 2026
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 8, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing Bot commented May 8, 2026

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 355dca6f57c6fec817d67765c566dc6ba6ac84bd --onto 5d5642107d0433519265f155ddbfbfb98007a80b. You can force Mathlib CI using the force-mathlib-ci label. (2026-05-08 10:18:48)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 48ad8401cd5624c944890893a38057ae4920e8ef --onto a71f158f7bd96ff9ea846f7ff4cc658de3c8b0f9. You can force Mathlib CI using the force-mathlib-ci label. (2026-05-11 14:26:13)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

leanprover-bot commented May 8, 2026

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 355dca6f57c6fec817d67765c566dc6ba6ac84bd --onto 5d5642107d0433519265f155ddbfbfb98007a80b. You can force reference manual CI using the force-manual-ci label. (2026-05-08 10:18:50)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 48ad8401cd5624c944890893a38057ae4920e8ef --onto a71f158f7bd96ff9ea846f7ff4cc658de3c8b0f9. You can force reference manual CI using the force-manual-ci label. (2026-05-11 14:26:15)

@wkrozowski wkrozowski marked this pull request as ready for review May 11, 2026 11:35
@wkrozowski
Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented May 11, 2026

Benchmark results for 18ac8ff against 48ad840 are in. No significant results found. @wkrozowski

  • 🟥 build//instructions: +4.4G (+0.04%)

Small changes (1🟥)

  • 🟥 build/module/Lean.Expr//instructions: +151.4M (+1.19%) (reduced significance based on *//lines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants