parser: fail upon duplicate declarations#24
Merged
Conversation
While most attacks involving duplicate declarations that actually prove False would still be caught if one delaration is simply ignored, it seems safer to catch this early and for all users of the parser. At least until someone comes up with a use case for duplicate declarations in the same file.
Contributor
Author
|
@hargoniX do any of your use cases require this to parse files with duplicate declarations? |
Contributor
|
No, I had previously thought about this and it seemed fine to me but I agree we should be paranoid, let's do it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While most attacks involving duplicate declarations that actually prove
False would still be caught if one delaration is simply ignored, it
seems safer to catch this early and for all users of the parser. At
least until someone comes up with a use case for duplicate declarations
in the same file.