verso-manual: Increase responsive layout breakpoints#686
Open
AmateurECE wants to merge 1 commit intoleanprover:mainfrom
Open
verso-manual: Increase responsive layout breakpoints#686AmateurECE wants to merge 1 commit intoleanprover:mainfrom
AmateurECE wants to merge 1 commit intoleanprover:mainfrom
Conversation
Previously, Theorem Proving in Lean4 had suboptimal layout on tablets. Increase the max-width thresholds in various media screen rules to trigger mobile layout changes on tablets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Many of the default media rules in verso trigger responsive layout changes when the screen size is at or below 700px. This works great for mobile, but makes sites rendered with verso a little awkward/uncomfortable to read at medium screen sizes, for example on tablets or in tiling window managers, where the sidebar takes up almost half of the screen.
I've increased some of these thresholds to 992px, chosen because it's the breakpoint for large screens in Bootstrap 5.0, and empirically this seemed to work better than larger breakpoints. I've built Theorem Proving in Lean 4 with these changes, and you can test/view them here: https://tpil.ethantwardy.com.