Merged
Conversation
Signed-off-by: Bradley Reynolds <bradley.reynolds@tailstory.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 88.29% 88.29%
=======================================
Files 3 3
Lines 94 94
=======================================
Hits 83 83
Misses 11 11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR adds the zizmor pre-commit hook for security auditing of GitHub Actions workflows and makes related workflow security improvements.
Changes:
- Added zizmor pre-commit hook and meta validation hooks to
.pre-commit-config.yaml - Updated noxfile.py to use "prek" instead of "pre-commit" command
- Improved GitHub Actions security by disabling credential persistence and scoping permissions appropriately
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .pre-commit-config.yaml | Adds meta hooks for validation, zizmor security hook, and removes check-json hook |
| noxfile.py | Changes pre-commit command to "prek" |
| .github/workflows/python-publish-pypi.yaml | Adds persist-credentials: false for security |
| .github/workflows/python-ci.yaml | Scopes id-token permission to specific job that needs it |
| .github/workflows/dependency-review.yaml | Adds persist-credentials: false for security |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.