Fix publish artifacts step to trigger on tag pushes#65
Merged
Conversation
The previous condition only matched refs/heads/main, so tag-triggered builds (releases) never ran sbt ci-release. Updated to also match tag refs, matching the approach recommended by sbt-ci-release docs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
danslapman
requested review from
Assassin4791,
InversionSpaces,
desavitsky and
edubrovski
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish artifactsstep hadif: github.ref == 'refs/heads/main', which only matched branch pushes — tag-triggered builds (releases) were silently skippedgithub.event_name == 'push' && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/')), matching the approach in sbt-ci-release's own release.ymlgithub.event_name == 'push'guard ensures secrets are never exposed during pull request buildsTest plan
main→ snapshot published (existing behaviour, unchanged)v*tag → release published to Maven Central viasbt ci-release🤖 Generated with Claude Code