Add position to pq.Error.Error() #1224
Merged
+88
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arp242
force-pushed
the
errpos
branch
2 times, most recently
from
85843cf to
99c2eeb
Compare
#1219 adds more detailed errors, but the regular .Error() can still be pretty useless for queries that are longer than a few lines: pq: invalid input syntax for type json (22P02) This adds the position to the .Error() message: pq: invalid input syntax for type json at position 5:8 (22P02) Or if there's just one line it adds just the column: pq: column "columndoesntexist" does not exist at column 8 (42703) Downside is that it's slower: original BenchmarkError-16 29751604 39 ns/op 48 B/op 1 allocs/op e.Position BenchmarkError-16 16639540 75 ns/op 112 B/op 2 allocs/op line:col BenchmarkError-16 3785821 315 ns/op 304 B/op 3 allocs/op The alternative is to just add the byte offset in there: pq: syntax error at or near ")" at offset 217 (42601) Which is faster and arguably cleaner, but ~300ns for getting an error message still seems fine to me as pq.Error messages are typically not really in a hot path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1219 adds more detailed errors, but the regular .Error() can still be pretty useless for queries that are longer than a few lines:
This adds the position to the .Error() message:
Or if there's just one line it adds just the column:
Downside is that it's slower:
The alternative is to just add the byte offset in there:
Which is faster and arguably cleaner, but ~300ns for getting an error message still seems fine to me as pq.Error messages are typically not really in a hot path.